Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert small integers of unknown type into i32 for driver adapters #5094

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: convert small integers of unknown type into i32 for driver adapters #5094

merged 2 commits into from
Dec 19, 2024

Conversation

jacek-prisma
Copy link
Contributor

@jacek-prisma jacek-prisma commented Dec 19, 2024 •
edited
Loading

Handling the unknown number type as i64 has caused issues with queryRaw when used from cfd1: all integers were being returned as BigInt, this tries to fit smaller ints into a smaller type to provide less surprising behavior

@jacek-prisma jacek-prisma requested a review from a team as a code owner December 19, 2024 11:41
@jacek-prisma jacek-prisma requested review from jkomyno and removed request for a team December 19, 2024 11:41
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5094 will not alter performance

Comparing fix/fit-unknown-number-into-i32 (32e51fa) with main (acc7a89)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.083MiB 2.083MiB 14.000B
Postgres (gzip) 837.653KiB 837.565KiB 90.000B
Mysql 2.048MiB 2.048MiB 10.000B
Mysql (gzip) 823.312KiB 823.454KiB -145.000B
Sqlite 1.961MiB 1.961MiB 14.000B
Sqlite (gzip) 788.387KiB 788.367KiB 21.000B

@aqrln aqrln added this to the 6.2.0 milestone Dec 19, 2024
@jacek-prisma jacek-prisma merged commit 4c6d8d3 into main Dec 19, 2024
342 checks passed
@jacek-prisma jacek-prisma deleted the fix/fit-unknown-number-into-i32 branch December 19, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-prisma @aqrln