fix(query-engine-wasm): add response_json_serialization span #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `prisma:engine:response_json_serialization` span in the WASM query engine. After this we can enable running the tracing tests with WASM in the client repo.
CodSpeed Performance ReportMerging #5089 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
jkomyno
approved these changes
Dec 16, 2024
aqrln
added a commit
that referenced
this pull request
Dec 16, 2024
Expand the scope of the `prisma:engine:query` span to contain both the request handler and the response serialization, identical to the Node-API engine, preventing `prisma:engine:response_json_serialization` from being orphaned outside the trace. This is a follow up to #5089.
jkomyno
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix(query-engine-wasm): expand scope of `prisma:engine:query` span Expand the scope of the `prisma:engine:query` span to contain both the request handler and the response serialization, identical to the Node-API engine, preventing `prisma:engine:response_json_serialization` from being orphaned outside the trace. This is a follow up to #5089. * [integration] * Add missing bits for transactions * [integration] * strip traceparents in attributes with driver adapters * [integration]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
prisma:engine:response_json_serializationspan in the WASM query engine. After this we can enable running the tracing tests with WASM in the client repo.