Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Replace os.path with pathlib and update ruff lint rules #797

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Chore: Replace os.path with pathlib and update ruff lint rules #797

merged 1 commit into from
Oct 10, 2024
+28 −12

Conversation

Prathamesh010
Copy link
Contributor

Reference Issues/PRs

Fixes #445

What does this implement/fix? Explain your changes.

Removed all instances of os.path and used pathlib

klieret
klieret approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@klieret klieret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@klieret klieret merged commit 77ce293 into princeton-nlp:main Oct 10, 2024
4 checks passed
@ofirpress
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klieret klieret klieret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace os.path with pathlib
3 participants
@Prathamesh010 @ofirpress @klieret