Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging by using traceback.format_exc() #787

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

manya706
Copy link
Contributor

@manya706 manya706 commented Oct 1, 2024

Closes #775

Reference Issues/PRs

Completed #775 : Add full tracebacks to all exception statements

What does this implement/fix? Explain your changes.

Added full tracebacks to all exception statements
This change will improve our ability to diagnose issues related to setting environment variables and retrieving commit hashes, providing clearer insights into the root causes of failures.

Files Modified

\SWE-agent\run.py
\SWE-agent\sweagent\agent\agents.py
\SWE-agent\sweagent\agent\summarizer.py
\SWE-agent\sweagent\environment\swe_env.py

@manya706 manya706 changed the title Improved logging by using traceback.format_exc() for automatic traceback Improved logging by using traceback.format_exc() Oct 1, 2024
Copy link
Member

@klieret klieret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klieret klieret merged commit 0aef099 into princeton-nlp:main Oct 3, 2024
4 checks passed
@manya706 manya706 deleted the add-traceback-to-logging branch October 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add full tracebacks to all exception statements
2 participants