Fix: Process done marker not found in read with timeout #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit shouldn't change anything
klieret
changed the title
This happened when both stderr and stdout were written to. There was no guarantee that the suffix that prints the exit status would actually be last. Fix: * Add a bit of timeout * Search in all lines rather than just the last one for the exit code Either of these should reasonably fix this. Closes #595
klieret
force-pushed
the
read-with-timeout-experimental-fix
branch
from
37327f4
to
1307e4d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 76.20% 76.28% +0.08%
==========================================
Files 21 21
Lines 3320 3319 -1
==========================================
+ Hits 2530 2532 +2
+ Misses 790 787 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #595
Fix: Process done marker not found in read with timeout
This happened when both stderr and stdout were written to.
There was no guarantee that the suffix that prints the exit status would
actually be last.
Fix:
Either of these should reasonably fix this.