forked from almende/vis
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Network: Retain constraint values in label font handling (almende#3520)
* Network: Retain constraint values in label font handling Fixes almende#3517. Due to changed logic in the label font handling, the option values for `widthConstraint` and `heightConstraint` were overwritten. The fix is in effect a reversal of two code lines: parsing constraint options should come *after* parsing (multi)font options. Further changes: - Additional 1-liner fix: constraint values were not copied for edge-instance specific options. - Small refactoriing of `Label#constrain()` in order to separate concerns - Added unit test for regression testing of this issue. This leads to the curious observation that, while the actual change is two lines of source code, this resulted in a +-150 line regression test. * Made unit test more linear, removed tabs * Made 'enhanced subset' of unit test * Removed TODO from comment * Culled redundant nodes from unit test
- Loading branch information
1 parent
b884c26
commit 9a6d949
Showing
3 changed files
with
175 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters