Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a pointservice #592

Merged
merged 46 commits into from
Feb 13, 2025
Merged

feat: adds a pointservice #592

merged 46 commits into from
Feb 13, 2025

Conversation

ckartik
Copy link
Contributor

@ckartik ckartik commented Feb 7, 2025

Add Points Accrual Service with Event Subscription, API Endpoints, and Initial SQLite DB
output

Summary

  • Introduces the PointsService managing a periodic points accrual routine (StartPointsRoutine) and event subscription for validator opt-ins/opt-outs.
  • Provides an HTTP API (PointsAPI) for querying points totals and block info.
  • Implements a basic SQLite data model with validator_records and last_processed_block tables, plus unit tests for computePointsForMonths.

Next Steps

  • Migrate the DB layer from SQLite to Postgres.
  • Move the service into our production infrastructure codebase, ensuring proper configuration (e.g., environment variables, container orchestration, etc.).

@ckartik ckartik requested a review from aloknerurkar February 7, 2025 03:00
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
x/contracts/events/events.go Outdated Show resolved Hide resolved
x/contracts/events/publisher/http.go Outdated Show resolved Hide resolved
@ckartik ckartik requested a review from aloknerurkar February 10, 2025 02:51
x/contracts/events/publisher/http.go Outdated Show resolved Hide resolved
x/contracts/events/publisher/http.go Outdated Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/api.go Show resolved Hide resolved
contracts-abi/script.sh Outdated Show resolved Hide resolved
@ckartik ckartik requested a review from aloknerurkar February 11, 2025 18:53
@ckartik ckartik changed the title feat: dynamic vault addresses + PointsService feat: Adds a PointsService Feb 11, 2025
@ckartik ckartik changed the title feat: Adds a PointsService feat: adds a pointservice Feb 11, 2025
Copy link
Collaborator

@aloknerurkar aloknerurkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the nit picks LGTM!

I would still be more comfortable if someone else also takes a look, make sure I havent missed anything. Maybe @shaspitz

tools/points-service/api.go Show resolved Hide resolved
tools/points-service/api.go Show resolved Hide resolved
tools/points-service/api.go Outdated Show resolved Hide resolved
tools/points-service/main.go Show resolved Hide resolved
tools/points-service/main.go Outdated Show resolved Hide resolved
tools/points-service/readme.md Show resolved Hide resolved
tools/points-service/api.go Show resolved Hide resolved
@ckartik
Copy link
Contributor Author

ckartik commented Feb 12, 2025

We've scaled down 10x and changed the curve shape of accrued points.

image

tools/points-service/readme.md Show resolved Hide resolved
tools/points-service/readme.md Show resolved Hide resolved
tools/points-service/readme.md Show resolved Hide resolved
tools/points-service/readme.md Show resolved Hide resolved
tools/points-service/api.go Show resolved Hide resolved
tools/points-service/api.go Show resolved Hide resolved
tools/points-service/main.go Show resolved Hide resolved
tools/points-service/main.go Show resolved Hide resolved
@ckartik ckartik requested a review from shaspitz February 12, 2025 23:18
@ckartik ckartik merged commit 6f82d06 into main Feb 13, 2025
5 checks passed
@ckartik ckartik deleted the ckartik/points-service branch February 13, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants