Remove OpenStruct from primer_octicon cop #3052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OpenStruct will not be included in modern Ruby versions, so we should not rely on it being there. This removes usage and instead builds the same class instance that is returned above. irb(main):003> h = RuboCop::AST::HashNode.new(hash) => s(:hash) irb(main):004> h.keys => [] irb(main):005> h.pairs => [] irb(main):006> h.type => :hash
HParker
force-pushed
the
remove-OpenStruct-usage
branch
from
c7693cb
to
8fafbbf
Compare
camertron
requested changes
Sep 4, 2024
Comment on lines
+277
to
+283
| def test_no_args | ||
| investigate(cop, <<-RUBY) | ||
| octicon | ||
| RUBY | ||
|
|
||
| assert_correction "primer_octicon" | ||
| end |
There was a problem hiding this comment.
It looks like the cop explicitly does nothing if no arguments are passed to the octicon method, so that's why this test is failing 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStruct will not be included in modern Ruby versions, so we should not rely on it being there. This removes usage and instead builds the same class instance that is returned above.