Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align group headers in Primer::Alpha::ActionMenu #2951

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jul 17, 2024

What are you trying to accomplish?

Group headers inside ActionMenus should always be left aligned, no matter how the menu itself is positioned.

Screenshots

Before

Bildschirmfoto 2024-07-17 um 13 23 21

After

Bildschirmfoto 2024-07-17 um 13 22 52

List the issues that this change affects.

Closes #2950

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@HDinger HDinger requested review from a team as code owners July 17, 2024 11:28
@HDinger HDinger requested review from langermank and removed request for a team July 17, 2024 11:28
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 6a43ffa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you! Could you add a changeset?

@HDinger
Copy link
Contributor Author

HDinger commented Jul 18, 2024

Nice thank you! Could you add a changeset?

Hi @camertron

I already added one, don't know why the changeset action still fails 🤷

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group headers are not correctly aligned when using anchor_align: :end in Primer::Alpha::ActionMenu
2 participants