Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text field and other form inputs respect the full_width: option #2673

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Mar 8, 2024

What are you trying to accomplish?

Some of our form inputs don't respect the full_width: argument and render full-width even when the argument is set to false.

Screenshots

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I chose to make the argument default to true, since that's effectively the current behavior.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: 7851825

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 8, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review March 11, 2024 16:40
@camertron camertron requested a review from a team as a code owner March 11, 2024 16:40
@camertron camertron requested review from broccolinisoup and jonrohan and removed request for broccolinisoup March 11, 2024 16:40
@camertron camertron merged commit 3a6762d into main Mar 12, 2024
31 checks passed
@camertron camertron deleted the full_width branch March 12, 2024 16:48
This was referenced Mar 8, 2024
jonrohan pushed a commit that referenced this pull request Mar 27, 2024
#2673)

Co-authored-by: camertron <camertron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants