Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documented options for ToggleSwitch size and status_label_position #2672

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

orhantoy
Copy link
Contributor

@orhantoy orhantoy commented Mar 8, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Fix ToggleSwitch docs

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated documentation

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@orhantoy orhantoy requested a review from a team as a code owner March 8, 2024 10:26
Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: 6fd89dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonrohan jonrohan enabled auto-merge (squash) March 8, 2024 18:01
@jonrohan jonrohan merged commit f1ab24a into main Mar 8, 2024
29 of 30 checks passed
@jonrohan jonrohan deleted the orhantoy/fix-toggle-switch-param-option-docs branch March 8, 2024 18:04
@primer primer bot mentioned this pull request Mar 8, 2024
@primer primer bot mentioned this pull request Mar 15, 2024
jonrohan added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants