Allow setting test_selector on select list options
#2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0b2f35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
approved these changes
Jan 10, 2024
camertron
requested changes
Jan 10, 2024
camertron
approved these changes
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
I was working on converting a form on dotcom to use the Primer form components (see https://github.com/github/github/pull/307881). We need to test in our component to make sure that certain options are included in the select menu, so we need to allow setting a test selector.
Integration
I don't think we need to change anything in prod for this?
List the issues that this change affects.
Closes #2494.
Risk Assessment
Just allows setting
data-test-selectorwhentest_selectoris included in the option arguments.What approach did you choose and why?
Used the
add_test_selectorhelper to include the selector in non-production environments. I didn't include anything to do the Primer classify stuff since I don't think you can/should set other Primer arguments on select options.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.