Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the utilities build not matching properly for font_size #2491

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jan 8, 2024

What are you trying to accomplish?

This fixes the utilities build for not matching all classes properly

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

The builder loops through the keys of the classname transforms and returns early when it gets a match. Moving the ^f fixes the issue because it matches the .f5 classes first.

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jonrohan jonrohan requested review from a team and camertron January 8, 2024 20:09
Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: a0c21dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron merged commit 11b1eec into main Jan 8, 2024
30 checks passed
@camertron camertron deleted the fixing_in_proper_classname_matching branch January 8, 2024 21:16
@primer primer bot mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants