Make dismiss action on Banner changeable #2454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 52905ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HDinger
changed the title
HDinger
force-pushed
the
fix/make-dismiss-action-translatable
branch
3 times, most recently
from
205290b
to
e87b69a
Compare
HDinger
force-pushed
the
fix/make-dismiss-action-translatable
branch
from
e87b69a
to
52905ae
Compare
|
Closing in favour of #2455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
Alpha::Bannercomponent has the option to dismiss the banner via a button showing an "x". This button has anaria-labelattribute with the hard coded text "Dismiss". This text is not changable. This PR aims to make the dismiss action customizable, e.g to open it for translations or different texts if the context requires it.List the issues that this change affects.
Closes #2453
Risk Assessment
Merge checklist