-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow previously hidden items to be checkable; add ActionMenu js API #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 47d0690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
changed the title
Don't allow previously hidden items to be checkable; add ActionMenu j…
Don't allow previously hidden items to be checkable; add ActionMenu js API
Nov 21, 2023
github-actions
bot
added
javascript
Pull requests that update Javascript code
ruby
Pull requests that update Ruby code
labels
Nov 21, 2023
camertron
requested review from
a team,
keithamus and
jonrohan
and removed request for
keithamus
November 22, 2023 23:04
jonrohan
approved these changes
Nov 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
minor release
ruby
Pull requests that update Ruby code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR does three things for the
ActionMenu
component:ActionMenu
to make it easier to hide, disable, and check items.itemActivated
whenever an item is activated by the mouse or keyboard.Integration
No changes necessary in production.
List the issues that this change affects.
Fixes https://github.com/github/primer/issues/2873
Risk Assessment
Accessibility
Merge checklist