Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade erblint-github to v0.5.1 #2361

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Upgrade erblint-github to v0.5.1 #2361

merged 1 commit into from
Nov 8, 2023

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

This PR upgrades erblint-github to the latest version, v0.5.1.

Integration

No changes necessary in production 👍

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/2834

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Bumped the gem and ran it, correcting all violations.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: feb0d86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron added the skip changeset Pull requests that don't change the library output label Nov 7, 2023
@camertron camertron marked this pull request as ready for review November 7, 2023 23:18
@camertron camertron requested review from a team and jonrohan November 7, 2023 23:18
@jonrohan
Copy link
Member

jonrohan commented Nov 8, 2023

I guess dependabot didn't take care of this because it's set to monthly in the config. Should we update to weekly?

@camertron
Copy link
Contributor Author

Hmm not sure. We were getting dinged by it on our scorecard. Probably couldn't hurt to upgrade to weekly.

@camertron camertron merged commit d37e2cc into main Nov 8, 2023
33 of 34 checks passed
@camertron camertron deleted the upgrade_erblint_051 branch November 8, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants