Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubocop issues and upgrade to latest versions #2356

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Nov 2, 2023

What are you trying to accomplish?

A recent PR bumped rubocop-github to the latest version, which unfortunately is now causing issues running Rubocop checks.

This PR upgrades github-rubocop and several of its dependencies to the latest versions. It also corrects a number of resulting Rubocop failures and adjusts the Rubocop configuration.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: 73a39d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Nov 2, 2023
@camertron camertron added the skip changeset Pull requests that don't change the library output label Nov 2, 2023
@camertron camertron marked this pull request as ready for review November 2, 2023 05:41
@camertron camertron requested review from a team and keithamus November 2, 2023 05:41
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks for this 👍🏻

@camertron
Copy link
Contributor Author

np!

@camertron camertron merged commit 8ad83de into main Nov 2, 2023
34 of 35 checks passed
@camertron camertron deleted the rubocop_upgrade branch November 2, 2023 16:44
@camertron camertron temporarily deployed to preview November 2, 2023 16:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants