Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltip design + fix v8 color tokens #2284

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Oct 13, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Match the updated design we're drafting in Primer React. Check out the design docs for more details.

  • Fixes the color tokens to use v8 with fallback
  • Removes the caret
  • Adjusts offset
  • Removes animation delay

Screenshots

See Lookbook

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@langermank langermank requested review from a team and keithamus October 13, 2023 19:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 6349c09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank temporarily deployed to preview October 13, 2023 19:26 — with GitHub Actions Inactive
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank marked this pull request as draft October 16, 2023 17:55
@langermank langermank merged commit 374d10f into main Oct 19, 2023
29 checks passed
@langermank langermank deleted the tooltip-design-refresh branch October 19, 2023 18:56
@langermank langermank temporarily deployed to preview October 19, 2023 18:56 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Oct 19, 2023
@langermank langermank mentioned this pull request Oct 23, 2023
8 tasks
@safeforge safeforge mentioned this pull request Dec 8, 2023
@langermank langermank restored the tooltip-design-refresh branch January 17, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants