Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'inactive' state to buttons #2283

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Adds 'inactive' state to buttons #2283

merged 7 commits into from
Oct 13, 2023

Conversation

mperrotti
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Add an "inactive" state to buttons to help resolve https://github.com/github/primer/issues/2676

This came from the work we did on graceful degradation patterns: https://primer.style/design/ui-patterns/degraded-experiences#indicating-a-button-is-non-functional-without-disabling-it

Screenshots

Screenshot 2023-10-12 at 4 07 47 PM

Integration

No updates to production code required

List the issues that this change affects.

Relates to https://github.com/github/primer/issues/2676

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I added a new parameter, inactive, that sets a button to aria-disabled. I chose this approach to align with the PRC API (PR: primer/react#3812)

Anything you want to highlight for special attention from reviewers?

Nothing in particular

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested a review from a team as a code owner October 12, 2023 20:10
@mperrotti mperrotti requested review from a team, tobiasahlin and jonrohan October 12, 2023 20:10
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: 4ab3eba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@github-actions github-actions bot added ruby Pull requests that update Ruby code css Pull requests that update CSS code labels Oct 12, 2023
@mperrotti mperrotti temporarily deployed to preview October 12, 2023 20:18 — with GitHub Actions Inactive
@mperrotti mperrotti temporarily deployed to preview October 13, 2023 14:57 — with GitHub Actions Inactive
@jonrohan jonrohan enabled auto-merge (squash) October 13, 2023 18:05
@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@jonrohan jonrohan merged commit da3bdb2 into main Oct 13, 2023
@jonrohan jonrohan deleted the mp/inactive-button-state branch October 13, 2023 18:22
@jonrohan jonrohan temporarily deployed to preview October 13, 2023 18:23 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code minor release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants