Fix tooltips opening when focus is removed while displaying #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue when, for example, a dialog with a tooltip on the show button closes and the focus changes, because the tool-tip element opens and doesn't get hidden when the focus moves away. This fixes that by registering a global focusin listener to check after a brief period of time if the showing tooltip was focussed into is still focussed. If it is not then it gets hidden. This in theory would create a small flash of the tooltip but our animations on tooltips gives us enough buffer so that the tooltip isn't visible right away.
🦋 Changeset detectedLatest commit: 981066a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
javascript
jonrohan
approved these changes
Oct 17, 2023
jonrohan
deleted the
fix-tooltips-opening-when-focus-is-removed-while-displaying
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue when, for example, a dialog with a tooltip on the show button closes and the focus changes, because the tool-tip element opens and doesn't get hidden when the focus moves away.
This fixes that by registering a global focusin listener to check after a brief period of time if the showing tooltip was focussed into is still focussed. If it is not then it gets hidden.
This in theory would create a small flash of the tooltip but our animations on tooltips gives us enough buffer so that the tooltip isn't visible right away.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Screenshots
Integration
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.