Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tracking #2262

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Release Tracking #2262

merged 2 commits into from
Oct 9, 2023

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Sep 29, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/view-components@0.11.0

Minor Changes

  • #2276 7184d76e Thanks @jonrohan! - Adding option item_arguments hash argument to ActionBar::Item that will control the item system arguments

  • #2259 a2fe6134 Thanks @TylerJDev! - * Includes ActionMenu in ActionBar focus trap when present.

    • Adjusts focus_group.ts to set tabindex="0" back to invoker if it is non-focusable.
    • Prevents popover invokers from being triggered with 'left' and 'right' arrow keys.

Patch Changes

  • #2260 b584a6b5 Thanks @camertron! - ActionMenu: hide the menu when focus leaves the component; focus the first list item when the menu is activated with the mouse; allow disabling list items while still permitting them to be focused with the keyboard

@primer primer bot requested review from a team and camertron September 29, 2023 20:44
@primer primer bot temporarily deployed to preview September 29, 2023 20:44 Inactive
@github-actions
Copy link
Contributor

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Lookbook opens in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate: npm i -w ./npm-workspaces/primer/ @primer/view-components@next
    • Update primer_view_components gem: script/vendor-gem https://github.com/primer/view_components.git -r changeset-release/main
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@primer primer bot force-pushed the changeset-release/main branch 3 times, most recently from e532f00 to 0f3ef12 Compare October 4, 2023 15:55
@primer primer bot temporarily deployed to preview October 4, 2023 15:55 Inactive
@primer primer bot temporarily deployed to preview October 4, 2023 16:11 Inactive
@primer primer bot temporarily deployed to preview October 4, 2023 22:21 Inactive
@primer primer bot force-pushed the changeset-release/main branch 2 times, most recently from 46820ae to f7ad019 Compare October 5, 2023 16:24
@primer primer bot temporarily deployed to preview October 5, 2023 16:24 Inactive
@jonrohan
Copy link
Member

jonrohan commented Oct 5, 2023

@primer primer bot temporarily deployed to preview October 6, 2023 17:17 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@jonrohan jonrohan merged commit d92acd9 into main Oct 9, 2023
@jonrohan jonrohan deleted the changeset-release/main branch October 9, 2023 17:13
@jonrohan jonrohan temporarily deployed to preview October 9, 2023 17:13 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant