-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overflow menu (ActionMenu
) to focus zone in ActionBar
#2259
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1e56a05
Add overflow menu (ActionMenu) to focus zone
TylerJDev 2f8799f
Some cleanup
TylerJDev af84132
Add changeset, adjust popover trigger keys
TylerJDev 56aea2c
Merge branch 'main' into tylerjdev/action-bar-focus-trap
TylerJDev 3cc3fe6
Merge branch 'main' into tylerjdev/action-bar-focus-trap
TylerJDev 93992b8
Add system test cases to `action_bar`
TylerJDev d14f530
Merge branch 'main' into tylerjdev/action-bar-focus-trap
TylerJDev eee388a
Fix test
TylerJDev cec8edb
Merge branch 'tylerjdev/action-bar-focus-trap' of https://github.com/…
TylerJDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
'@primer/view-components': minor | ||
--- | ||
|
||
* Includes ActionMenu in ActionBar focus trap when present. | ||
* Adjusts `focus_group.ts` to set `tabindex="0"` back to invoker if it is non-focusable. | ||
* Prevents popover invokers from being triggered with 'left' and 'right' arrow keys. | ||
|
||
<!-- Changed components: Primer::Alpha::ActionBar, Primer::Alpha::ActionMenu --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents the left and right arrow keys from triggering a menu. Without, if you were to navigate the ActionBar with arrow keys, the menu would automatically open when either key is pressed.