-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dismiss button in Flash with IconButton #2222
Conversation
🦋 Changeset detectedLatest commit: 6725c1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I want to get @maximedegreve's review before merging this |
Hmm, can you fix the deploy so we can see it in Lookbook? |
Looks good. Thank you for fixing this @jonrohan |
What are you trying to accomplish?
Fixing https://github.com/github/primer/issues/2550 by replacing the custom dismiss button with a PVC
IconButton
Screenshots
Visual Diffs
Integration
No
List the issues that this change affects.
Closes https://github.com/github/primer/issues/2550
Risk Assessment
What approach did you choose and why?
There was some padding adjustment I did for the position of the button.
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.