Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support with_leading_visual_svg in Primer::Beta::Button #2215

Merged
merged 13 commits into from
Aug 22, 2023
Merged

Support with_leading_visual_svg in Primer::Beta::Button #2215

merged 13 commits into from
Aug 22, 2023

Commits on Aug 18, 2023

  1. Add leading_visual_svg to button component

    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    185490b View commit details
    Browse the repository at this point in the history

  2. add with_leading_visual_svg example to lookbook

    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    113d4e7 View commit details
    Browse the repository at this point in the history

  3. use more descriptive labels for buttons

    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    33c3f51 View commit details
    Browse the repository at this point in the history

  4. add test

    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2c7ea67 View commit details
    Browse the repository at this point in the history

  5. Generating component snapshots

    @mjimenez98 @github-actions
    mjimenez98 authored and github-actions[bot] committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f9592c4 View commit details
    Browse the repository at this point in the history

  6. fix ids for buttons in preview

    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    89904f9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'mj98-pri-bls' of https://github.com/primer/view_components 

     into mj98-pri-bls
    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    65bb542 View commit details
    Browse the repository at this point in the history

  8. add changeset

    @mjimenez98
    mjimenez98 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    322b533 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. create new preview for button with leading svg icon

    @mjimenez98
    mjimenez98 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e6dd38f View commit details
    Browse the repository at this point in the history

  2. fill leading svg icon with current color for button and action_list

    @mjimenez98
    mjimenez98 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b7aedb4 View commit details
    Browse the repository at this point in the history

  3. Generating component snapshots

    @mjimenez98 @github-actions
    mjimenez98 authored and github-actions[bot] committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    41121e8 View commit details
    Browse the repository at this point in the history

  4. fix stylelint error -- make currentColor lowercase

    @mjimenez98
    mjimenez98 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c792800 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'mj98-pri-bls' of https://github.com/primer/view_components 

     into mj98-pri-bls
    @mjimenez98
    mjimenez98 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bb34249 View commit details
    Browse the repository at this point in the history