Give buttons more inspiring names

[keithamus]

What are you trying to accomplish?

We've had a slew of new accessibility violations raised on our various buttons for not being descriptive enough. I personally think this is a mistake because the issues claim that button Button is not descriptive, ignoring the fact that the Button is an example button with the literal name Button - it is as descriptive as the visual representation... alas I digress...

Giving these buttons more inspiring names will demonstrate clearly that ATs describe the visuals, and there will be no more ambiguity around button Button.

Screenshots

Integration

List the issues that this change affects.

Closes https://github.com/github/accessibility-audits/issues/5423
Closes https://github.com/github/accessibility-audits/issues/5419
Closes https://github.com/github/accessibility-audits/issues/5418
Closes https://github.com/github/accessibility-audits/issues/5414
Closes https://github.com/github/accessibility-audits/issues/5412

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

• Fixes axe scan violation - This change fixes an existing axe scan violation.
• No new axe scan violation - This change does not introduce any new axe scan violations.
• New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 49cd56d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

[v-prahu]

@keithamus: As checked on all these 5 issues, it is still assigned to one of the testers. We have a process of two level review on bugs logged and unassign it when review is complete. We will review these bugs and update the details accordingly.