add aria-invalid when fields are invalid #2201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
During an accessibly review of https://github.com/github/github/pull/283228 it was noted that when we add the
invalid
attribute to an input element we should also be adding thearia-invalid
attribute.Integration
N/A
Risk Assessment
What approach did you choose and why?
I modified
Primer::Forms::Dsl::Input
to includearia-invalid
as needed.Anything you want to highlight for special attention from reviewers?
Are there other places I should be adding tests for this?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.