Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aria-invalid when fields are invalid #2201

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

kintner
Copy link
Contributor

@kintner kintner commented Aug 10, 2023

What are you trying to accomplish?

During an accessibly review of https://github.com/github/github/pull/283228 it was noted that when we add the invalid attribute to an input element we should also be adding the aria-invalid attribute.

Integration

N/A

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I modified Primer::Forms::Dsl::Input to include aria-invalid as needed.

Anything you want to highlight for special attention from reviewers?

Are there other places I should be adding tests for this?

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@kintner kintner requested review from a team and camertron August 10, 2023 21:02
@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: afda32b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@camertron camertron merged commit ba90a43 into main Aug 10, 2023
28 checks passed
@camertron camertron deleted the kintner/aria-invalid branch August 10, 2023 22:43
@primer primer bot mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants