Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling submit buttons #2188

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Aug 2, 2023

What are you trying to accomplish?

In a recent PR, I removed the ability to disable submit buttons in the Primer forms framework. Unfortunately dotcom includes a use-case where I believe disabling the submit button is valid, so unfortunately the framework needs to allow it.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests

@camertron camertron requested a review from jonrohan August 2, 2023 18:42
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: a3b7c1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron merged commit 5950afe into main Aug 2, 2023
31 checks passed
@camertron camertron deleted the allow_disabling_submit_buttons branch August 2, 2023 20:08
@primer-css primer-css mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants