Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for capitalize to text-transform #2170

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

Tonkpils
Copy link
Contributor

@Tonkpils Tonkpils commented Jul 31, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Add support for capitalize on text-transform. It's already supported by the CSS class text-capitalize https://primer.style/design/foundations/css-utilities/typography#typographic-styles

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Added the change to the list where these utilities are already defined

Anything you want to highlight for special attention from reviewers?

Is there anything else that needs to be updated?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: 9978e64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron
Copy link
Contributor

Shoot, sorry @Tonkpils! That change to utilities.yml was required to get tests to pass. I ran rake utilities:build which added it back in. Apologies for the noise.

@camertron camertron merged commit 4391873 into main Aug 1, 2023
26 of 28 checks passed
@camertron camertron deleted the tonkpils/text-capitalize branch August 1, 2023 22:40
@primer-css primer-css mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants