Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallbacks for primary Button #2163

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Add fallbacks for primary Button #2163

merged 7 commits into from
Jul 27, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jul 27, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Copies the old CSS before the new vars were used. This removes the inset shadow, even though we believe that's the intended design.

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@langermank langermank requested a review from a team as a code owner July 27, 2023 19:46
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: d73f3a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Jul 27, 2023
@langermank langermank requested review from a team and camertron July 27, 2023 19:47
@langermank langermank temporarily deployed to preview July 27, 2023 19:47 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages July 27, 2023 19:51 — with GitHub Actions Inactive
@langermank langermank marked this pull request as draft July 27, 2023 20:05
@langermank langermank temporarily deployed to preview July 27, 2023 20:15 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages July 27, 2023 20:18 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank marked this pull request as ready for review July 27, 2023 21:17
@jonrohan jonrohan merged commit e3aeda1 into main Jul 27, 2023
@jonrohan jonrohan deleted the button-css-fallbacks branch July 27, 2023 21:17
@primer-css primer-css mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants