Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move System Arguments page to Lookbook #2159

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Move System Arguments page to Lookbook #2159

merged 4 commits into from
Jul 26, 2023

Conversation

mperrotti
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

These changes generate a page for System Arguments in Lookbook so that we can remove the page from primer.style.

Integration

No known integration changes

List the issues that this change affects.

Closes https://github.com/github/primer/issues/2492

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Took the existing args data and generated a .md.erb to create a new Lookbook page. A separate PR will be opened in primer/design that will remove the Systems Arguments page and update links to go to Lookbook.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and camertron July 26, 2023 17:33
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 37f75f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mperrotti mperrotti temporarily deployed to preview July 26, 2023 17:34 — with GitHub Actions Inactive
@mperrotti mperrotti temporarily deployed to github-pages July 26, 2023 17:38 — with GitHub Actions Inactive
@camertron camertron added the skip changeset Pull requests that don't change the library output label Jul 26, 2023
@camertron camertron merged commit c1e5192 into main Jul 26, 2023
28 of 29 checks passed
@camertron camertron deleted the mp/add-sys-args-pg branch July 26, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants