Add lint rule against .tooltipped and introduce accessibility.yml config

[khiga8]

What are you trying to accomplish?

I started this rule in dotcom, but then I realized that PVC might make more sense so this rule can be shared across many projects.

This PR:

• Introduce a lint rule against .tooltipped in favor of alternatives, or the more recent tooltip.
• Started a accessibility.yml which will allow consumers to easily pull in recommended accessibility linting configurations which we can count against the scorecard. This will specifically contain rules that count towards the accessibility scorecard.
• I moved helpers out of base_linter.rb to a helpers module. BaseLinter seems to come with a lot of additional things this rule doesn't need, but I need to use these helpers.

I think consumers can now add the following in their .erb-lint.yml to automatically pull in rules:

inherit_gem:
  primer_view_components:
    - primer/view_components/linters/accessibility.yml

Integration

No

List the issues that this change affects.

Closes https://github.com/github/accessibility/issues/3704

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

• I introduced a accessibility.yml config so consumers can easily configure recommended rules.
• I namespaced the rule as Primer::Accessibility.

Anything you want to highlight for special attention from reviewers?

I namespaced the rule Primer::Accessibility:: to align with what we do in erblint-github.

The pro of this is that it can help to identify where a rule originates from. The con, is that the disable comment is kind of long (e.g. `erblint:disable Primer::Accessibility::TooltipHasMigration).

This also isn't consistent with the other rules living in PVC. What do you think? @primer/rails-reviewers?? 📣

I would also like to add docs for this rule but I'm not sure where it belongs, also given the doc migration work. What do you think? 📣

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 073b0cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[camertron]

This looks good to me 👍 Have you tested that it works without choking in dotcom?

Also, could you add a changeset?

[khiga8]

This looks good to me 👍 Have you tested that it works without choking in dotcom?

I'll give it a try! And also fix the tests, which are breaking for some reason :(

[khiga8]

Have you tested that it works without choking in dotcom?

@camertron I started a test branch using the vendor script and pointing to this commit in dotcom. I updated the .erb-lint.yml config and got this rule running, and tried inserting inline disables. 💪

The one unexpected thing was the path which I had to set to get this config to work: Related commit. I did not expect to need to prefix the path to the config with lib. I didn't need to do that with erblint-github. I wonder why? It's not a blocker though.

[khiga8]

Since this was last reviewed, I made these updates @primer/rails-reviewers:

• Updated logic to include class as suggested in Add lint rule against .tooltipped and introduce accessibility.yml config #2086 (comment)
• Fixed breaking tests by prefixing :: to some of the Primer helper calls.
• Enabled this config for this project aa18004 and added tests to make sure the config pulls in rules as expected.

Your input is appreciated here:

• Add lint rule against .tooltipped and introduce accessibility.yml config #2086 (comment)
• Add lint rule against .tooltipped and introduce accessibility.yml config #2086 (comment)

Thank you so much 🙏.

[jonrohan]

Looks good including the :: prefix 👍🏻