-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavList: Add aria-current to active nav item #2075
Conversation
🦋 Changeset detectedLatest commit: 9579cc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camertron - I had originally brought this up in the #primer-rails channel because of https://github.com/github/accessibility-audits/issues/3650. That issue suggests a solution of not just aria-current="true"
but aria-current="page"
. Do we know if the value of the attribute will make a difference to the user? Maybe @primer/accessibility-reviewers might have more context.
Woops! Good catch @jamieshark, I will fix that asap. Based on these docs, |
…ents into nav_list_aria_current
What are you trying to accomplish?
This PR updates
NavList
so that the currently active nav item has anaria-current
attribute set on it.Integration
No changes necessary in production.
List the issues that this change affects.
Fixes https://github.com/github/primer/issues/2313
Risk Assessment
Accessibility
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)- [ ] Tested in Chrome- [ ] Tested in Firefox- [ ] Tested in Safari- [ ] Tested in EdgeTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.