Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak popover css #2055

Merged
merged 6 commits into from
Jun 7, 2023
Merged

tweak popover css #2055

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
264822f
tweak popover css
keithamus Jun 1, 2023
071ed48
add comments
keithamus Jun 1, 2023
8b93a9d
Add changeset
camertron Jun 6, 2023
9dac14b
Debug
camertron Jun 6, 2023
e2a0035
Disable autoprefixer for already-compiled CSS
camertron Jun 6, 2023
8def7ce
Merge branch 'main' into tweak-popover-css
keithamus Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions app/components/primer/alpha/overlay.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,23 @@
padding: 0;
position: absolute;
min-width: 192px;
inset: auto;
}

/* stylelint-disable-next-line selector-pseudo-class-no-unknown */
.Overlay[popover]:not(:popover-open) {
.Overlay[popover]:not(.\:popover-open) {
display: none;
}

anchored-position {
display: block;
/* This reverts the declaration above for native popover, where `:popover-open` is supported */
@supports selector(:popover-open) {
.Overlay[popover]:not(.\:popover-open) {
display: revert;
}
}

/* This reverts the declaration above for native popover, where `:open` is supported (Chrome 113, Safari TP) */
@supports selector(:open) {
.Overlay[popover]:not(.\:popover-open) {
keithamus marked this conversation as resolved.
Show resolved Hide resolved
display: revert;
}
}