enable focussing first element on space activation #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e55540 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
javascript
camertron
approved these changes
May 25, 2023
Merged
jonrohan
pushed a commit
that referenced
this pull request
May 25, 2023
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focus on activation of the action menu can happen in multiple ways, primary keyboard behaviour is via Space or Enter.
Currently we have logic to determine the key-press is happening, and focus the first element in the popover. This only happens on
Enterthough, which means whenSpaceis pressed, the invoker is still focussed.This fixes that by checking if any of the
Space/Enteractivation keys are pressed.I'd like to eventually remove this code because it should be handled by popover but need to investigate why it isn't.
Integration
Merge checklist