Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve aria-label when icon button show_tooltip is false #2025

Merged
merged 3 commits into from
May 30, 2023

Conversation

strackoverflow
Copy link
Member

Closes #1986

Co-authored-by: Joel Hawksley <joelhawksley@github.com>
@strackoverflow strackoverflow requested review from a team and keithamus May 22, 2023 19:23
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: 8193ef0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label May 22, 2023
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@jonrohan jonrohan merged commit 2d1f507 into main May 30, 2023
@jonrohan jonrohan deleted the icon-button-fix-aria-label branch May 30, 2023 16:26
@primer-css primer-css mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set aria-label on IconButton if tooltips are disabled
3 participants