prevent default when showing dialog

[keithamus]

Description

In Chrome Dev with Experimental Web Platform features enabled, I noticed that pressing Enter on a button to open a dialog will also trigger a pointer event (simulating the click of the button). This happens in a task after the keypress, and so the code does the following:

• Chrome fires a keypress event for the Enter key.
• The Enter key is on a data-show-dialog-id button, so dialog.show() is called.
• Chrome fires a click pointer event.
• The dialog is in the open state, but the click event is on an element outside the dialog, so dialog.hide() is called.

The effect of this is that the dialog is never shown. We can combat this by calling event.preventDefault() on the click when the dialog is being shown. This prevents the pointer event from being fired.

Closes # (type the issue number after # if applicable; otherwise remove this line)

Integration

Does this change require any updates to code in production?

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews

[changeset-bot]

🦋 Changeset detected

Latest commit: 6a59c6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR