Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popover open selector for focus group #2002

Merged
merged 4 commits into from
May 11, 2023

Conversation

keithamus
Copy link
Member

Description

The focus group code doesn't work for popovers due to the use of the outdated selector. This changes the selector to the new popover-open selector.

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@keithamus keithamus requested review from a team and camertron May 11, 2023 09:48
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: c189220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus temporarily deployed to preview May 11, 2023 09:48 — with GitHub Actions Inactive
@github-actions github-actions bot added javascript Pull requests that update Javascript code patch release labels May 11, 2023
@keithamus keithamus temporarily deployed to github-pages May 11, 2023 09:52 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant