Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct psuedo selector for popover #1998

Merged
merged 2 commits into from
May 10, 2023
Merged

use correct psuedo selector for popover #1998

merged 2 commits into from
May 10, 2023

Conversation

keithamus
Copy link
Member

Description

popover has changed to use :popover-open

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@keithamus keithamus requested a review from a team as a code owner May 10, 2023 14:23
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: fdccd63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label May 10, 2023
@keithamus keithamus requested review from a team and camertron May 10, 2023 14:26
@keithamus keithamus merged commit a23d553 into main May 10, 2023
@keithamus keithamus deleted the fix-popover-open-css branch May 10, 2023 16:20
@primer-css primer-css mentioned this pull request May 10, 2023
Merged
camertron pushed a commit that referenced this pull request May 19, 2023
@keithamus @camertron
use correct psuedo selector for popover (#1998)
8a86c45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan left review comments

@langermank langermank langermank approved these changes

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann is a code owner automatically assigned from primer/css-reviewers

@camertron camertron Awaiting requested review from camertron

Assignees
No one assigned
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithamus @jonrohan @langermank