Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to latest erblint #1947

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Upgrading to latest erblint #1947

merged 2 commits into from
Apr 14, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 11, 2023 •
edited
Loading

Description

This upgrades to the latest erb-lint release, which includes functionality for inline disables. This is a smaller bit of this pr #1944 that I pulled out to make updating easier.

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a040fff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan temporarily deployed to preview April 11, 2023 22:40 — with GitHub Actions Inactive
@jonrohan jonrohan temporarily deployed to github-pages April 11, 2023 22:44 — with GitHub Actions Inactive
@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label Apr 12, 2023
@jonrohan jonrohan marked this pull request as ready for review April 12, 2023 20:10
@jonrohan jonrohan requested review from a team and keithamus April 12, 2023 20:10
@jonrohan jonrohan enabled auto-merge (squash) April 12, 2023 20:14
@jonrohan jonrohan requested a review from camertron April 12, 2023 20:14
camertron
camertron approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonrohan jonrohan merged commit 3ff749d into main Apr 14, 2023
@jonrohan jonrohan deleted the upgrade_erblint branch April 14, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @camertron