Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use of removed slots api #1932

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix use of removed slots api #1932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363bc1f
fix use of removed slots api
joelhawksley Apr 4, 2023
b39fa75
Create .changeset/rude-keys-invite.md
joelhawksley Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-keys-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Fix use of removed slots API in docs.
6 changes: 3 additions & 3 deletions app/components/primer/beta/border_box.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class BorderBox < Primer::Component
#
# @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
# @accessibility
# When using header.title, the recommended tag is a heading tag, such as h1, h2, h3, etc.
# When using header.with_title, the recommended tag is a heading tag, such as h1, h2, h3, etc.
renders_one :header, "Primer::Beta::BorderBox::Header"

# Optional Body.
Expand Down Expand Up @@ -72,8 +72,8 @@ class BorderBox < Primer::Component

# @example Header with title, body, rows, and footer
# <%= render(Primer::Beta::BorderBox.new) do |component| %>
# <% component.with_header do |h| %>
# <% h.title(tag: :h2) do %>
# <% component.with_header do |header| %>
# <% header.with_title(tag: :h2) do %>
# Header
# <% end %>
# <% end %>
Expand Down