Suggest ViewComponents on reserved class use #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e1269c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
neall
force-pushed
the
neall/suggestions-for-css-class-linting
branch
from
69641e7
to
ed91bb7
Compare
neall
force-pushed
the
neall/suggestions-for-css-class-linting
branch
from
ed91bb7
to
845486f
Compare
When developers use HTML classes that we reserve for Primer ViewCompoents, we want to suggest relevant components they might want to use instead.
neall
force-pushed
the
neall/suggestions-for-css-class-linting
branch
from
845486f
to
5e1269c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When developers use HTML classes that we reserve for Primer ViewCompoents, we want to suggest relevant components they might want to use instead.
Closes Primer#1901
Implementation
This changes the generated
static/classes.jsonfile from a pure array of HTML classes to restrict into an object where the keys are those HTML classes and the values are arrays of the Ruby class (or classes) associated with that HTML class.Merge checklist
[ ] Added/updated documentation[ ] Added/updated previews