Fix width of text fields and multi inputs #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 66db473 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
changed the title
camertron
requested review from
a team,
keithamus and
jonrohan
and removed request for
keithamus
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a few forms in dotcom right now that look kinda funky:
Text inputs
A recent PR wrapped text inputs in the
<primer-text-field>custom element, which has no styling. The framework expects all inputs to be wrapped with theFormControlclass, which sets some necessaryflex-*rules. This PR ensures this class is attached to<primer-text-field>and not one if its children.Multi inputs
Multi inputs suffer from the same problem, although the
<primer-multi-input>custom element has been around for a bit longer.Integration
No
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews