Modify merge_aria to combine plural attributes; introduce merge_data #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b8c7be7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Mar 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've had a
#merge_ariamethod for a little while now that handles merging aria attributes from system arguments. The problem is a bit tricky because aria attributes can be passed as a hash with anaria:key (eg.aria: { foo: "bar" }) or as individual key/value pairs (eg."aria-foo": "bar").I had a need today to handle so-called "plural" aria attributes like aria-describedby and aria-labelledby, which support multiple space-delimited values, eg.
aria-labelledby="foo bar". I also wanted to handledataattributes.I will submit another PR soon that actually uses these methods.
Integration
No
Merge checklist
- [ ] Added/updated previews