Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm currently working on updating
ActionMenu
(an experimental component in dotcom) to use theActionList
component instead of HTML + action list classes. So what's changed?ActionList
(andNavList
), I recently added a requiredlabel:
argument. Labels used to be specified via content. Unfortunately numerous places in dotcom specify non-trivial content inActionMenu
items, meaningActionList
items have to support content again too.ActionList
designs, dividers can either be horizontal lines or text. This PR makes the latter possible.Integration
No