Allow ActionList dividers to be added manually #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 530218b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Mar 10, 2023
| # @param system_arguments [Hash] The arguments accepted by <%= link_to_component(Primer::Alpha::ActionList::Divider) %>. | ||
| def with_divider(**system_arguments, &block) | ||
| # This is a giant hack that should be removed when :items can be converted into a polymorphic slot. | ||
| # This feature needs to land in view_component first: https://github.com/ViewComponent/view_component/pull/1652 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dividers in an
ActionListcan currently only be added by passingshow_dividers: true, which will add a divider between each list item:I'm working on integrating
ActionListinsideActionMenu(currently an experimental component in dotcom) that needs to be able to insert dividers manually at user-defined positions within the list. This PR introduces the#with_dividermethod which offers such functionality. Here's an example:Why not use polymorphic slots?
This is a use-case tailor-made for polymorphic slots, but using them would necessitate a painful API change. Fortunately custom polymorphic slot names are on the horizon, but until then I've added a bit of a hacky workaround in the form of a
#with_dividermethod that appends to the existingitemsslot using ViewComponent's private#set_slotmethod.Integration
Merge checklist