Allow NavList selection/deselection by id/href in javascript #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 852528b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
review-pr-1822
GitHub Actions
Inactive
github-actions
bot
added
javascript
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
review-pr-1822
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Error
…onents into nav_list_select_item_id
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Failure
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Failure
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Failure
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Failure
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Failure
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
requested a deployment
to
review-pr-1822
GitHub Actions
Abandoned
camertron
had a problem deploying
to
review-pr-1822
GitHub Actions
Failure
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
review-pr-1822
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
reviewed
Feb 14, 2023
keithamus
reviewed
Feb 14, 2023
keithamus
reviewed
Feb 14, 2023
keithamus
approved these changes
Feb 14, 2023
camertron
temporarily deployed
to
review-pr-1822
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
approved these changes
Feb 16, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have logic in dotcom for automatically selecting
NavListitems when navigating via turbo. A lot of this logic depends on the internal HTML structure of theNavList, which is probably going to break in the near future when I start addressing a11y feedback. Moreover, the existing dotcom behavior doesn't properly expand the parent section if the selected item is a sub item of a section. This PR addresses both concerns by exposing a JavaScript API for selecting items by id, href, or the current URL. A significant portion of this code was copied and tweaked from dotcom.It would be cool to upstream the turbo logic too, but selecting by id relies on setting a
<meta>tag in the page header, which IMHO isn't something PVC should do.Integration
No, dotcom code should continue to work as expected since none of the underlying HTML is changing. However once this is shipped I will submit a dotcom PR to call our new JavaScript API functions, which will obviate a good deal of dotcom code.
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews