Standalone form control #1821
Merged
Standalone form control #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 401b9ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
temporarily deployed
to
review-pr-1821
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
force-pushed
the
form_control
branch
from
3fdca82
to
03de788
Compare
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
review-pr-1821
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
temporarily deployed
to
review-pr-1821
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
camertron
temporarily deployed
to
review-pr-1821
GitHub Actions
Inactive
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Jon Rohan <rohan@github.com>
camertron
had a problem deploying
to
review-pr-1821
GitHub Actions
Error
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly for parity with primer/react, this PR adds a
FormControlcomponent. It wraps arbitrary content with a label, optional caption, and optional validation message. Under normal circumstances, hubbers would use the Primer forms framework, which has its own version ofFormControl. This component can be used outside of a forms context.Integration
No.
Merge checklist