Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade button component in dialog #1753

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Jan 6, 2023

Description

Per slack (staff only link)

It looks like the Primer::Alpha::Dialog uses the method with_show_button which generates the deprecated Primer::ButtonComponent and it has different CSS classes than Primer::Beta::Button
Will the Primer::Alpha::Dialog component be updated to show the Primer::Beta::Button button?

Integration

Does this change require any updates to code in production?

We will need to check Dialog show_button slots for incompatible system arguments from the old button

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2023

🦋 Changeset detected

Latest commit: 7ccb567

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jan 6, 2023
@keithamus keithamus temporarily deployed to github-pages January 6, 2023 14:35 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@keithamus keithamus marked this pull request as ready for review January 6, 2023 15:00
@keithamus keithamus requested review from a team and jonrohan January 6, 2023 15:00
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we'll need to search for here is all the uses of the Dialog component and check that the with_show_button slot isn't passing arguments that are deprecated. https://primer.style/view-components/guides/primer_button_component

@jonrohan jonrohan enabled auto-merge (squash) January 6, 2023 23:02
@jonrohan jonrohan temporarily deployed to github-pages January 6, 2023 23:07 — with GitHub Actions Inactive
@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label Jan 6, 2023
@jonrohan jonrohan merged commit 95df035 into main Jan 6, 2023
@jonrohan jonrohan deleted the upgrade-button-component-in-dialog branch January 6, 2023 23:13
@primer-css primer-css mentioned this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants