-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade button component in dialog #1753
Conversation
🦋 Changeset detectedLatest commit: 7ccb567 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing we'll need to search for here is all the uses of the Dialog component and check that the with_show_button
slot isn't passing arguments that are deprecated. https://primer.style/view-components/guides/primer_button_component
Description
Per slack (staff only link)
Integration
We will need to check Dialog show_button slots for incompatible system arguments from the old button
Merge checklist