Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Primer::OcticonComponent to Primer::Beta::Octicon #1690

Merged
merged 9 commits into from
Dec 8, 2022
Merged

Move Primer::OcticonComponent to Primer::Beta::Octicon #1690

merged 9 commits into from
Dec 8, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 8, 2022 •
edited
Loading

Description

this PR moves Primer::OcticonComponent to Primer::Beta::Octicon, and deprecates the original

Integration

Does this change require any updates to code in production?

none immediately, but deprecations need to be cleaned up

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 572ace5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@mxriverlynn mxriverlynn force-pushed the mxriverlynn/move-octicon-component branch from 4617a8f to 10a8f66 Compare December 8, 2022 14:39
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1690 December 8, 2022 14:40 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 8, 2022 14:45 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn mentioned this pull request Dec 8, 2022
Closed
54 tasks
@mxriverlynn mxriverlynn force-pushed the mxriverlynn/move-octicon-component branch from beacbbb to 2f4fd1f Compare December 8, 2022 15:02
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1690 December 8, 2022 15:02 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 8, 2022 15:06 — with GitHub Actions Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label Dec 8, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 8, 2022 15:28 — with GitHub Actions Inactive
@github-actions github-actions bot removed the css Pull requests that update CSS code label Dec 8, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 8, 2022 15:35 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 8, 2022 17:12
@mxriverlynn mxriverlynn requested a review from a team December 8, 2022 17:12
jonrohan
jonrohan approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮‍💨 this is gonna be a big one

@mxriverlynn mxriverlynn merged commit c1845c6 into main Dec 8, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/move-octicon-component branch December 8, 2022 19:31
@primer-css primer-css mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@camertron camertron Awaiting requested review from camertron

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxriverlynn @jonrohan