Update tooltip to run setup on connectedCallback instead of relying on attributeChangedCallback #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n attributeChangedCallback
🦋 Changeset detectedLatest commit: 77170e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
approved these changes
Dec 7, 2022
manuelpuyol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
khiga8
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Nice fix and cleanup!
In the past, we've run into issues with #updatePosition method being called on page load which led to performance issues on pages with hundreds of tooltips (since calculating position is expensive). It doesn't seem like this PR introduces that issue so this seems fine to me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like when we navigate using a Turbo Frame in dotcom, due to some Turbo internals,
attributeChangedCallbackruns before the element is added to the DOM tree. This causescontrolto not be found (since it's also not in the tree) and the setup is skipped. In this case,controlwill not have the correctaria-attributes.With this change, I'm guaranteeing that the setup always runs when the
tool-tipconnects to the page.Integration
Nope, this should be a no-op in terms of functionality
Merge checklist